Merged
Conversation
OEvgeny
previously approved these changes
Oct 22, 2025
OEvgeny
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
Description
This pull request bump the Chrome used in Web Chat for testing, from version 110 to 141.
There are 1,234 out of 1,473 screenshots failed.
Differences are listed in the following sections. Some differences may need investigation and potentially corrections. And some are good and we should adopt the new screenshots.
Differences (need to investigate)
(Everything done.)
Differences (adopted)
Sub-pixel font rendering
Darker button border
Modernized scroll bar
Scroll position changed for 1 pixel
Could be related to decimal place handling.
Bubble border (@2x)
Padding in Math error box
The red error box is added for testing purpose only. It looks better in Chrome 141.
Math thinner scroll bar
Chrome 121 supports CSS
scrollbar-width: thin.File attachment preview text-only button size (white-label only)
This is actually correct. Chrome 121 supports CSS
scrollbar-width: thinand thus, the container is 2 pixels wider.Squiggle in feedback form
Lorem ipsum texts has squiggles. We did not set
spellcheckattribute in white-label or Fluent, so it is expected to see squiggles.Focusable date/time picker
The picker button was not a focusable in Chrome 110. Now it is focusable.
Send box enlarged while completion is shown in (Fluent only)
Seems related to how Chrome handle
line-heightin the doppelganger for completion appended as<span>. The completion would cause the send box to be taller by 1 pixel. Fixed in CSS of the test file.Code block pushed down 1 pixel
It seems it is related to monospace font spacing and line height changes. Original is
padding-block: 12px. To tweak Chrome 141 to looks like Chrome 110, we needpadding-block: 11px 13px, which seems overkill.We are adopting the new monospace padding style.
If using
11px/13px, will looks like below, but we are not adopting an asymmetric padding.Code block line height (white-label only)
With a 14px monospace font,
line-height: normalin Chrome 110 was 1.21em or 16.94px. However, in Chrome 141,line-height: normalis 1em or 14px. Adopting the new line height change for white-label.<dialog>has darker backdropWe should set
dialog::backdropto bergba(0, 0, 0, 0.4)(light theme) andrgba(0, 0, 0, 0.5)(dark theme) to match Fluent UI, however, we are setting it toundefined(--colorTransparentBackground). That means, we are using the shading from user agent stylesheet.Chrome 110 does not have shading for
::backdrop, but Chrome 141 does have.<summary>lengthAuto-fit
<summary>width matches Fluent UI design so we are adopting it.Flair animation in Fluent looks taller and better
anchor-nameandposition-anchoris supported in Chrome 125.Icon in pre-chat is gone (Fluent only)
Due to bad data in the base64.
Inconsistent RGB/BGR sub-pixel rendering
Chrome sometimes render with RGB/BGR, another times with grayscale. We are disabling RGB/BGR through
--disable-lcd-textfor consistencies.Stats before
Stats before modifying the tests:
There are 1,732 tests and 1,473 screenshots (counting PNG files under
/__tests__/html2and/__tests__/__image_snapshots__.)22 skipped tests are related to speech, where a speech key (not token) is required. They are usually skipped.
Design
Specific Changes
--single-process, otherwise Chrome will fail on execute, possibly argument is removed--headlessis not quite working#webchatand take screenshot, because we have<dialog>and it will depends on viewport sizetoMatchImageSnapshot()will not fail in-place, but fail atdone()<input type="radio">must have eitheridorname<form>, would fail some tests under/html2/feedbackForm/window.Observable = undefinedin legacy tests to disable native ES Observable--disable-lcd-textfor consistenciesCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)